Remiplement Add to use reflection.

Now it matters whether `FieldLabel`s are spelled correctly, but in return, we don't have to write and maintain that obnoxious `switch` statement.

koboldsim/cardtypes.go

@@ -9,7 +9,6 @@ import (
 var (
 	ErrOptionNotEnabled = errors.New("option not enabled")
 	ErrPolicyNotEnacted = errors.New("cannot unenact policy that is not enacted")
-	ErrNoFieldLabel     = errors.New("field does not exist")
 
 	// ErrUnimplemented and ErrKeepMessaage are "non-errors". They are used
 	// as special signals that the result needs to be handled in a special way;

koboldsim/stats.go

@@ -1,7 +1,9 @@
 package koboldsim
 
 import (
+	"errors"
 	"fmt"
+	"reflect"
 
 	"git.chromaticdragon.app/kistaro/CardSimEngine/cardsim"
 )
@@ -167,6 +169,10 @@ func NewKoboldMine() *KoboldMine {
 	}
 }
 
+// FieldLabel instances are strings exactly matching the name of an
+// exported field in `KoboldMine`. These are used to map field names to
+// amounts to change in `TablePolicy` instances, which are then looked
+// up by name (via reflection) when adding the stat.
 type FieldLabel string
 
 const (
@@ -188,56 +194,51 @@ const (
 	Secrecy          FieldLabel = "Secrecy"
 )
 
-func (k *KoboldMine) Add(which FieldLabel, amount float64) error {
+// ErrBadFieldLabel is an "error category" for all errors where a
-	switch which {
+// FieldLabel did not correctly name a Field that could be used in Add.
-	case Authoritarianism:
+var ErrBadFieldLabel = errors.New("bad field label")
-		k.Authoritarianism += amount
+
-		return nil
+// ErrNoFieldLabel is a kind of `ErrBadFieldLabel` used when no field
-	case BasePopulation:
+// of the target has the exact name specified in the FieldLabel. Check
-		k.BasePopulation += amount
+// spelling and capitalization.
-		return nil
+var ErrNoFieldLabel = fmt.Errorf("%w: field does not exist", ErrBadFieldLabel)
-	case Bureaucracy:
+
-		k.Bureaucracy += amount
+// ErrFieldNotFloat is a kind of `ErrBadFieldLabel` used when it is not
-		return nil
+// possible to read and assign a float to the named field. Is this the
-	case Construction:
+// name of a calculated stat (a function) rather than a base stat?
-		k.Construction += amount
+var ErrFieldNotFloat = fmt.Errorf("%w: field type is not float", ErrBadFieldLabel)
-		return nil
+
-	case Cruelty:
+// ErrFieldSetPanic is a kind of `ErrBadFieldLabel` used when trying to
-		k.Cruelty += amount
+// set the value of a field panicked. The panic message should be
-		return nil
+// preserved in the error to diagnose the problem. If the problem is
-	case Education:
+// that the field is unexported, capitalize the name (including inside
-		k.Education += amount
+// the KoboldMine type). Any other issue is a more complicated bug,
-		return nil
+// because all of them that aren't already caught by ErrFieldNotFloat
-	case FoodSupply:
+// imply something very unexpected happened with `k` itself (in `Add`).
-		k.FoodSupply += amount
+var ErrFieldSetPanic = fmt.Errorf("%w: panic when setting", ErrBadFieldLabel)
-		return nil
+
-	case ForeignRelations:
+// Use a FieldLabel to add an amount to the matching field. If no such
-		k.ForeignRelations += amount
+// field can be found, the field is not exported, or the field is not
-		return nil
+// of type float64, this returns an error ad does not change any values.
-	case Gullibility:
+func (k *KoboldMine) Add(which FieldLabel, amount float64) (finalErr error) {
-		k.Gullibility += amount
+	kv := reflect.ValueOf(k).Elem()
-		return nil
+	f := kv.FieldByName(string(which))
-	case Madness:
+	if !f.IsValid() {
-		k.Madness += amount
+		return fmt.Errorf("cannot add %f to field %q: %w", amount, which, ErrNoFieldLabel)
-		return nil
-	case Manufacturing:
-		k.Manufacturing += amount
-		return nil
-	case Mining:
-		k.Mining += amount
-		return nil
-	case Militarism:
-		k.Militarism += amount
-		return nil
-	case Rebellion:
-		k.Rebellion += amount
-		return nil
-	case Scavenging:
-		k.Scavenging += amount
-		return nil
-	case Secrecy:
-		k.Secrecy += amount
-		return nil
 	}
-	return fmt.Errorf("cannot add %f to %q: %w", amount, which, ErrNoFieldLabel)
+	if !f.CanFloat() {
+		return fmt.Errorf("cannot add %f to field %q: %w", amount, which, ErrFieldNotFloat)
+	}
+
+	defer func() {
+		if r := recover(); r != nil {
+			if e, ok := r.(error); ok {
+				finalErr = fmt.Errorf("could not add %f to field %q: %w: %w", amount, which, ErrFieldSetPanic, e)
+			} else {
+				finalErr = fmt.Errorf("could not add %f to field %q: %w: %v", amount, which, ErrFieldSetPanic, r)
+			}
+		}
+	}()
+	f.SetFloat(f.Float() + amount)
+	return nil
 }