pyrex/fledgling
1
0
Fork 0
Code Issues 17 Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid creating rooms with no exits #29

New Issue
Closed
opened 2025-02-18 06:34:16 +00:00 by pyrex · 3 comments
pyrex commented 2025-02-18 06:34:16 +00:00
Owner
Copy Link

Right now the player can end up in a room with no exits. This is apparently caused by some bug in how we account for junctions. So uh, fix that!

Right now the player can end up in a room with no exits. This is apparently caused by some bug in how we account for junctions. So uh, fix that!
pyrex added the
refactor
 label 2025-02-18 06:48:43 +00:00
pyrex added the
Importance
Postponed
 label 2025-02-22 19:51:04 +00:00
kistaro self-assigned this 2025-02-23 00:45:57 +00:00
kistaro changed title from Fix map generator bugs to Avoid creating rooms with no exits 2025-02-23 00:47:19 +00:00
kistaro commented 2025-02-23 01:36:07 +00:00
Collaborator
Copy Link

The code that was ported to produce mapgen.ts, this specific Dart code associated with this blog post, has been updated in the interim as it becomes a thing for a specific game with a lot of rewriting since then, but I discovered a specific revision in the changelogs that refers to the exact symptom being described here: the description of the commit "Make dungeons and mixed style levels more robust." includes, as part of one of its bullet points, "Fixes cases where you'd get a solitary starting room."

So that makes me suspect the port is faithful and has faithfully created a bug. Looking into this patch to see what looks like it would fix this bug, and then figuring out how to mentally map that back to the original design of this map generator, and from there onto its TypeScript counterpart.

The code that was ported to produce `mapgen.ts`, [this specific Dart code](https://github.com/munificent/hauberk/blob/db360d9efa714efb6d937c31953ef849c7394a39/lib/src/content/dungeon.dart) associated with [this blog post](https://journal.stuffwithstuff.com/2014/12/21/rooms-and-mazes/), has been updated in the interim as it becomes a thing for a specific game with a lot of rewriting since then, but I discovered a specific revision in the changelogs that refers to the exact symptom being described here: the description of the commit ["Make dungeons and mixed style levels more robust."](https://github.com/munificent/hauberk/commit/16628af5c95eb034bd05e5742fb71fa1d041ea62#diff-10954c11b89bf5e9ccd333cc57d73927c99a012e21ebf506d7ea3209961b04d1) includes, as part of one of its bullet points, "Fixes cases where you'd get a solitary starting room." So that makes me suspect the port is faithful and has faithfully created a bug. Looking into this patch to see what looks like it would fix this bug, and then figuring out how to mentally map that back to the original design of this map generator, and from there onto its TypeScript counterpart.
kistaro commented 2025-02-23 01:52:03 +00:00
Collaborator
Copy Link

The patch I found on the original repo is probably for a different issue. Oh well.

The patch I found on the original repo is probably for a different issue. Oh well.
pyrex closed this issue 2025-02-23 05:43:14 +00:00
kistaro added reference fix-mapgen 2025-02-23 05:45:06 +00:00
kistaro removed reference fix-mapgen 2025-02-23 05:45:11 +00:00
kistaro commented 2025-02-23 05:46:12 +00:00
Collaborator
Copy Link

Fixed in #39 .

Fixed in #39 .
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
art
This is primarily a change to the pixel assets
core
This is needed for the game to function on a basic level.
good first issue
Kistaro! Work on these.
Importance
Important
This should be done before end of February
Importance
Postponed
This issue doesn't need to be done right now.
polish
This makes the game feel nice to play, but it's not essential
refactor
The code is bad: fix it!
speculative
"I don't know if this is a good idea yet."
No Label
Importance
Postponed
refactor
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bhijn kistaro pyrex
No Assignees kistaro
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pyrex/fledgling#29
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?