pyrex/chameleonic
1
1
Fork 1
Code Issues Pull Requests 2 Packages Projects Releases Wiki Activity

Replace multiple pal calls with a single pal-table call, or some pokes. #5

Merged
pyrex merged 1 commits from kistaro/chameleonic:optimize-palette into main 2022-12-18 02:24:42 +00:00
Conversation 1 Commits 1 Files Changed 1
+15 -11
kistaro commented 2022-12-18 02:11:49 +00:00
Contributor
Copy Link
Copy Source

The pokes could also just be a single pal call with a table, but I think the loop might actually be faster than constructing the table (!).

This can be optimized further by declaring the color table as a global variable so it is not rebuilt on every call, but I didn't read the code closely enough to discover if there's logic for body parts changing color, which I didn't want to break.

The pokes could also just be a single pal call with a table, but I think the loop might actually be faster than constructing the table (!). This can be optimized further by declaring the color table as a global variable so it is not rebuilt on every call, but I didn't read the code closely enough to discover if there's logic for body parts changing color, which I didn't want to break.
kistaro added 1 commit 2022-12-18 02:11:50 +00:00
Replace multiple pal calls with a single pal-table call, or some pokes. 5e3ca803b7
pyrex approved these changes 2022-12-18 02:24:38 +00:00
pyrex merged commit 0821ae2bd7 into main 2022-12-18 02:24:42 +00:00
kistaro deleted branch optimize-palette 2022-12-19 07:03:58 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
pyrex
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
pyrex (Pyrex)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pyrex/chameleonic#5