Replace multiple pal calls with a single pal-table call, or some pokes. #5

kistaro · 2022-12-18T02:11:49Z

kistaro commented

2022-12-18 02:11:49 +00:00

The pokes could also just be a single pal call with a table, but I think the loop might actually be faster than constructing the table (!).

This can be optimized further by declaring the color table as a global variable so it is not rebuilt on every call, but I didn't read the code closely enough to discover if there's logic for body parts changing color, which I didn't want to break.

The pokes could also just be a single pal call with a table, but I think the loop might actually be faster than constructing the table (!). This can be optimized further by declaring the color table as a global variable so it is not rebuilt on every call, but I didn't read the code closely enough to discover if there's logic for body parts changing color, which I didn't want to break.

kistaro added 1 commit 2022-12-18 02:11:50 +00:00

Replace multiple pal calls with a single pal-table call, or some pokes. 5e3ca803b7

pyrex approved these changes 2022-12-18 02:24:38 +00:00

pyrex merged commit 0821ae2bd7 into main

2022-12-18 02:24:42 +00:00

pyrex referenced this issue from a commit

2022-12-18 02:24:43 +00:00

Replace multiple pal calls with a single pal-table call, or some pokes. (#5)

kistaro deleted branch optimize-palette

2022-12-19 07:03:58 +00:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: pyrex/chameleonic#5