WIP: sprintf #21

kistaro · 2023-01-01T22:00:45Z

kistaro commented

2023-01-01 22:00:45 +00:00

This one goes on top of better_debug_mouse.

This implements a sprintf function that might be useful for complex text output. At this point, I don't think this should actually be merged because of the performance and token cost. I'll see if there's a way to golf this to make it come out ahead on tokens but it's currently fifty tokens behind so it might not be worth it unless you see a lot more uses for it.

This one goes on top of better_debug_mouse. This implements a sprintf function that might be useful for complex text output. At this point, **I don't think this should actually be merged** because of the performance and token cost. I'll see if there's a way to golf this to make it come out ahead on tokens but it's currently fifty tokens behind so it might not be worth it unless you see a lot more uses for it.

kistaro added 10 commits 2023-01-01 22:00:45 +00:00

Better debug mouse e878717c31

Debug mouse is now its own module, so it can be separated from the hint system, since it is useful for more than just positioning hints. It now has the following enhancements:

1. Clock-based table cyclng now has a helper function (cycle)
2. Debug mouse color cycling is distinct from hint color cycling, so debug position readout remains legible
3. Debug position readout now stays on screen even when the cursor is near or past the edges
4. Debug cursor cycles between a mouse sprite specifically marking the exact pixel that is being sampled, an "X" for text character sizing, and a "□" for positioning the centered 3x3 characters often used as hint target markers
5. Map cell coordinates (in square brackets) are displayed in addition to pixel coordnates (in parentheses)

Sprite 50 is now the mouse cursor. Color 15 is color cycling for debug readouts.

Debug mouse features can be disabled by commenting out `add(real_modules, debugmouse)`.

I've done a little bit of golfing but this is stiill a token expense. I'm going to write a crappy sprintf function to save tokens everywhere we're assembling strings from their component parts.

implement fake sprintf 3494c48e74

this spends extra tokens to handle "invalid format character" to catch using a % where %% is intended. this is designed to grow with further format chars if needed; I have ideas for not-exactly-POSIX %d, %x, %h, %!, %#, %c, and possibly others but there is absolutely no reason to spend tokens on these things until we need them. (that said, existing debugging output might benefit from some of these other formats, but that debug code is commented out, so maybe nevert.)

fix sprintf and rename to fmt 93c154f876

the "split on %" strategy makes parsing "%%" complicated, so the "actually literally %" placeholder is now "%~" rather than "%%". since thsi resembles a real sprintf even less now I renamed it to "fmt".

also actually closes the `if m == "~"` block. (which was `if m == "%"` before this patch)

fix double-consume, add %! 2264349e72

I discovered your tostring function for debugging, might as well make it reachable from fmt.  I also realized I forgot to convert to using "p" when I introduced it so I fixed that

fix section before first "%" 3516d2855e

oops, need to special-case the first part of the split list.

amusingly, I don't need to special-case zero-length format strings because that will skip the entire loop and output "", which seems correct. (I am also not special-casing zero-length segments because `s[1] == nil` will go into the error handler and that seems fine.

Use fmt on title screen. e6c35dbeda

tostring golf f86e52d3bd

this could be golfed further by rewriting the str..= line in terms of fmt, but the performance impact of inserting the extra `fmt` calls and parsing into the tostring recursion seems likely to be a problem.

golf recollide_reanchor 46f1339e19

Uses fmt in recollide_reanchor. This has a performance impact in code that is already slow so this might need to be reverted; I think that should be part of a comprehensive optimization pass, however, and making it worse for now as part of a general code cleanup is probably better.

use fmt in a commented-out debug logging block 3e2229be65

fmt in debugmouse:draw3. ce3fc83221

This is literally the reason I implemented fmt in the first place

kistaro added 1 commit 2023-01-01 22:11:17 +00:00

assert on unrecognized directive e028209adf

saves four tokens and is more diagnostic.

This pull request has changes conflicting with the target branch.

chameleonic.p8

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u sprintf:kistaro-sprintf

git checkout kistaro-sprintf

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: pyrex/chameleonic#21